Custom fmt formatter for ustringhash prints the string, not the hash #3614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, change `operator<<` to output the string, not the hash itself. These changes help push us more toward the original intent of ustringhash being a drop-in replacement for ustring, any time it's more desirable to be using around the hashes rather than the pointers.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 22, 2022
…cademySoftwareFoundation#3614) Also, change `operator<<` to output the string, not the hash itself. These changes help push us more toward the original intent of ustringhash being a drop-in replacement for ustring, any time it's more desirable to be using around the hashes rather than the pointers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, change
operator<<to output the string, not the hash itself. These changes help push us more toward the original intent of ustringhash being a drop-in replacement for ustring, any time it's more desirable to be using the hashes rather than the pointers.